Fixed: Vault warns when valid JSON contains special character sequences #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional context around this issue can be found in: |
Open
10 tasks
jaymzh
reviewed
Nov 26, 2024
spec/chef/helper_spec.rb
Outdated
| end | ||
|
|
||
| it "Not to raise error if valid data provided" do | ||
| expect { validate_json(json_data) }.to_not raise_error | ||
| it "should not to raise error if valid data provided" do |
spec/chef/helper_spec.rb
Outdated
| end | ||
|
|
||
| it "not to raise error if data consist of tab/new line OR space" do | ||
| it "should not to raise error if data consist of tab/new line OR space" do |
decoyjoe
force-pushed
the
bugfix/vault-warns-when-item-contains-special-characters
branch
from
6ebf263 to
e959039
Compare
decoyjoe
force-pushed
the
bugfix/vault-warns-when-item-contains-special-characters
branch
from
e959039 to
f4ad81a
Compare
jaymzh
approved these changes
Nov 26, 2024
|
Hey @johnmccrae - I think this is related to powershell stuff? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where Chef Vault writes a warning when a valid JSON document contains special character sequences, exposing sensitive vault data in the warning message.
Chef Vault should be agnostic to the content of the vault item JSON. It no longer inspects vault item contents, validation responsibility is left to the JSON parser to ensure the JSON data is valid.
Related Issue
Fixes #415 Chef Vault warns and leaks secrets when vault json contains properly encoded special characters · Issue #415 · chef/chef-vault
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.