Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHEF-1516 Fixed the --chef-license issue #3097

Merged
merged 3 commits into from
Apr 17, 2023
Merged

CHEF-1516 Fixed the --chef-license issue #3097

merged 3 commits into from
Apr 17, 2023

Conversation

nikhil2611
Copy link
Contributor

@nikhil2611 nikhil2611 commented Apr 12, 2023 •
edited
Loading

Description

Redirected the --chef-license flow to the chef-cli for the chef env command.

Related Issue

#fixed: #3061

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@nikhil2611
redirecting to chef-cli for --chef-license flag
131143b 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611 nikhil2611 requested review from a team as code owners April 12, 2023 08:35
@netlify
Copy link

netlify bot commented Apr 12, 2023 •
edited
Loading

👷 Deploy Preview for chef-workstation processing.

Name Link
🔨 Latest commit 29add18
🔍 Latest deploy log https://app.netlify.com/sites/chef-workstation/deploys/643c2cee1692d900082f2c2e

@nikhil2611
souting to cli for all flags
23f6fcb 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@nikhil2611
updated the variables name
29add18 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqube-for-infrastructure-prod
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nikhil2611 nikhil2611 requested a review from sanghinitin April 17, 2023 06:10
@nikhil2611 nikhil2611 merged commit 52fa7f6 into main Apr 17, 2023
@nikhil2611 nikhil2611 deleted the nikhil/chef-env-license-issue branch April 17, 2023 11:06
@nikhil2611 nikhil2611 added the Expeditor: Skip All Used to skip all merge_actions. label Apr 17, 2023
@vkarve-chef vkarve-chef changed the title FIxed the --chef-license issue CHEf-1516 Fixed the --chef-license issue Apr 18, 2023
@vkarve-chef vkarve-chef changed the title CHEf-1516 Fixed the --chef-license issue CHEF-1516 Fixed the --chef-license issue Apr 18, 2023
@nikhil2611 nikhil2611 changed the title CHEF-1516 Fixed the --chef-license issue CHEF-1516 Fixed the chef env --chef-license issue Apr 18, 2023
@nikhil2611 nikhil2611 changed the title CHEF-1516 Fixed the chef env --chef-license issue CHEF-1516 Fixed the --chef-license issue Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanghinitin sanghinitin sanghinitin approved these changes

@ashiqueps ashiqueps ashiqueps approved these changes

Assignees
No one assigned
Labels
Expeditor: Skip All Used to skip all merge_actions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chef Workstation v23.2.1028 unable to accept license
3 participants
@nikhil2611 @ashiqueps @sanghinitin