Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve FFI warnings from bundled tooling #904

Closed
tas50 opened this issue Jan 29, 2020 · 1 comment
Closed

Resolve FFI warnings from bundled tooling #904

tas50 opened this issue Jan 29, 2020 · 1 comment
Labels
Status: Untriaged An issue that has yet to be triaged.

Comments

@tas50
Copy link
Contributor

tas50 commented Jan 29, 2020

FFI 1.12 introduced warnings if you try to override a struct layout, which we are apparently doing. I'm pinning to < 1.12, but we need 1.12 for Ruby 2.7 support. This needs to get fixed in our deps.

It produces output similar to this (this is actually from DK, but it's the same)

C:/opscode/chefdk/embedded/lib/ruby/gems/2.6.0/gems/ffi-1.12.1-x64-mingw32/lib/ffi/struct.rb:207:in `layout': [DEPRECATION] Struct layout is already defined for class Windows::ServiceStructs::SERVICE_STATUS_PROCESS. Redefinition as in C:/opscode/chefdk/embedded/lib/ruby/gems/2.6.0/gems/win32-service-2.1.4/lib/win32/windows/structs.rb:72:in `<class:SERVICE_STATUS_PROCESS>' will be disallowed in ffi-2.0. (StructuredWarnings::StandardWarning)

Chef Workstation Version

latest

Platform Version

Windows

@tas50 tas50 added the Status: Untriaged An issue that has yet to be triaged. label Jan 29, 2020
@tas50
Copy link
Contributor Author

tas50 commented Feb 4, 2020

This is fixed with #914

@tas50 tas50 closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Untriaged An issue that has yet to be triaged.
Projects
None yet
Development

No branches or pull requests

1 participant