Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect usage of poise-hoist cookbook #351

Closed
7 tasks
tas50 opened this issue Oct 24, 2019 · 3 comments
Closed
7 tasks

Detect usage of poise-hoist cookbook #351

tas50 opened this issue Oct 24, 2019 · 3 comments
Labels
New Cop Proposal A proposal for a new Cookstyle cop

Comments

@tas50
Copy link
Contributor

tas50 commented Oct 24, 2019

What category of cop is this?:

Please try to select as few as possible.

  • Deprecation - A cop that alerts to a deprecation in the Chef Infra Client
  • Correctness - A cop that alerts when incorrect coding behavior is being used
  • Sharing - A cop that alerts to missing functionality necessary for sharing cookboooks with others
  • Style - A cop that alerts to a style best practice
  • Simplification - A cop that alerts to ways code can be simplified through refactoring
  • Effortless - A cop that alerts on code that must be resolved to move to the Effortless pattern
  • Policyfiles - A cop that alerts on code that must be resolved to move to the Policyfiles pattern

Describe the new cop:

poise-hoist is no longer maintained and the functionality is mostly built into Chef Infra Client itself now.

What it would trigger on:

depends 'poise-hoist'
@tas50 tas50 added Status: Untriaged An issue that has yet to be triaged. New Cop Proposal A proposal for a new Cookstyle cop and removed Status: Untriaged An issue that has yet to be triaged. labels Oct 24, 2019
@tyler-ball tyler-ball added this to the November 18 - November 29 milestone Nov 15, 2019
@tyler-ball
Copy link
Contributor

The complexity here comes not from writing the rules, but figuring out what we suggest to users as the correct replacement.

@Swathisivakumar
Copy link

Can we at least trigger a warning on dependency of poise-hoist since most people use only the hoisting feature and the suggested fix would to just remove the dependency but because of the risk we shouldn't do an autocorrect.

User who depend on other feature of poise-hoist can ignore the warning.

@tas50
Copy link
Contributor Author

tas50 commented Jan 14, 2022

Closed by #928

@tas50 tas50 closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Cop Proposal A proposal for a new Cookstyle cop
Projects
None yet
Development

No branches or pull requests

3 participants