Always write lockfiles for local top-level profiles #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is based on #1113 |
stevendanna
force-pushed
the
ssd/write-lockfiles
branch
from
8436868 to
d2deed3
Compare
chris-rock
reviewed
Sep 21, 2016
| @@ -60,6 +60,8 @@ def self.exec_options | |||
| desc: 'Load attributes file (experimental)' | |||
| option :cache, type: :string, | |||
| desc: 'Use the given path for caching dependencies. (default: ~/.inspec/cache)' | |||
| option :no_write_lockfile, type: :boolean, default: false, | |||
There was a problem hiding this comment.
that is leading to a strange cli output:
[--no-write-lockfile], [--no-no-write-lockfile] # Do not write out a lockfile based on this execution
I think we need to switch to write-lockfile with default true
There was a problem hiding this comment.
maybe create-lockfile, since otherwise I am thinking its overwriting the old lockfile
| @@ -55,6 +55,10 @@ def archive_path | |||
| @target | |||
| end | |||
|
|
|||
| def writable? | |||
| File.directory?(@target) | |||
There was a problem hiding this comment.
Not all directories are writable
There was a problem hiding this comment.
True, in this context by writable? we simply mean "is this the type of source that I actually want to write new files into on disk". We may still fail with EACCESS or something when we go to write.
chris-rock
reviewed
Sep 21, 2016
| if profile.lockfile_exists? | ||
| Inspec::Log.debug "Using existing lockfile #{profile.lockfile_path}" | ||
| else | ||
| Inspec::Log.debug "Writing lockfile: #{profile.lockfile_path}" |
This commit threads through some state related to whether or not a profile is "local", that is whether it is a directory on disk. If it is, we then write out the lockfile to disk. Signed-off-by: Steven Danna <steve@chef.io>
Signed-off-by: Steven Danna <steve@chef.io>
chris-rock
force-pushed
the
ssd/write-lockfiles
branch
from
b70a9fa to
d29e876
Compare
|
Thanks @stevendanna |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit threads through some state related to whether or not a
profile is "local", that is whether it is a directory on disk. If it
is, we then write out the lockfile to disk.
Signed-off-by: Steven Danna steve@chef.io