extend the attributes object with helper methods #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chris-rock
commented
Oct 14, 2016
chris-rock
commented
- add helper methods
- allow the attribute object to generate ruby code
chris-rock
force-pushed
the
chris-rock/extend-attribute-object
branch
2 times, most recently
from
0a097c0 to
cca17f9
Compare
alexpop
reviewed
Oct 18, 2016
| end | ||
|
|
||
| def ruby_var_identifier | ||
| 'attr_' + @name.downcase.strip.tr(' ', '-').gsub(/[^\w-]/, '') |
There was a problem hiding this comment.
PR looks good. What you think of updating this slug maker from:
[10] pry> " hello\tdear spaces\n".downcase.strip.tr(' ', '-').gsub(/[^\w-]/, '')
=> "hellodear--spaces"To:
[11] pry> " hello\tdear spaces\n".downcase.strip.gsub(/\s+/, '-').gsub(/[^\w-]/, '')
=> "hello-dear-spaces"There was a problem hiding this comment.
good point, lets use your approach
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/extend-attribute-object
branch
from
cca17f9 to
c67ff8b
Compare
|
Looks good, merging. Thanks Chris! |
|
Should this also have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.