derive xinetd protocol from socket_type when not defined in the config file #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpop
force-pushed
the
ap/implicit-protocols
branch
from
8c1f8e4 to
b46d9df
Compare
alexpop
changed the title
…g file Signed-off-by: Alex Pop <apop@chef.io>
alexpop
force-pushed
the
ap/implicit-protocols
branch
from
b46d9df to
495185b
Compare
chris-rock
reviewed
Feb 1, 2017
| it 'params has only the protocols parsed from the config files' do | ||
| one = resource.params['services']['chargen'].map{|x| x.params['protocol']} | ||
| # in this example(CentOS), protocol is not defined in the config | ||
| _(one).must_equal [nil, nil] |
There was a problem hiding this comment.
I like this separation! Thank you @alexpop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://msdn.microsoft.com/en-us/library/system.net.sockets.sockettype(v=vs.110).aspx
From my research, the most common
socket_typevalues arestream(TCP) anddgram(UDP). There's no implicit protocol forrawandseqpacket.