reading binary profile data on windows #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlimus
force-pushed
the
dr/windows-binary-io
branch
from
d375fdc to
962654c
Compare
|
@chris-rock this is the one you have been hunting for 😁 |
arlimus
added a commit
that referenced
this pull request
Jun 8, 2017
On Windows, `inspec archive` would sometimes produce incorrect archive files. These would look fine, as tgz files, but would not execute correctly. This would lead to bewildering error messages like this one: ``` Unable to parse inspec.yml: line 1, control characters are not allowed ``` Fix it by treating the files as binary before writing them to get around any encoding issues, since the stream handler is a raw io object anyway. Closely related to #1906
arlimus
added a commit
that referenced
this pull request
Jun 8, 2017
On Windows, `inspec archive` would sometimes produce incorrect archive files. These would look fine, as tgz files, but would not execute correctly. This would lead to bewildering error messages like this one: ``` Unable to parse inspec.yml: line 1, control characters are not allowed ``` Fix it by treating the files as binary before writing them to get around any encoding issues, since the stream handler is a raw io object anyway. Closely related to #1906
arlimus
added a commit
that referenced
this pull request
Jun 8, 2017
On Windows, `inspec archive` would sometimes produce incorrect archive files. These would look fine, as tgz files, but would not execute correctly. This would lead to bewildering error messages like this one: ``` Unable to parse inspec.yml: line 1, control characters are not allowed ``` Fix it by treating the files as binary before writing them to get around any encoding issues, since the stream handler is a raw io object anyway. Closely related to #1906 Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
chris-rock
approved these changes
Jun 8, 2017
On Windows, we ran into the problem that the execution of inherited profiles would (sometimes) not work. This was due to the use of `File.read` and `File.write` and handling inside the file provider, which works in most cases (especially *nix systems), but does not behave as expected on Windows. A better and more correct way of treating these files is via binary read and write mode, which changes the underlying encoding of both strings that are passed along. Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
chris-rock
force-pushed
the
dr/windows-binary-io
branch
from
962654c to
a8dd4d0
Compare
chris-rock
pushed a commit
that referenced
this pull request
Jun 8, 2017
On Windows, `inspec archive` would sometimes produce incorrect archive files. These would look fine, as tgz files, but would not execute correctly. This would lead to bewildering error messages like this one: ``` Unable to parse inspec.yml: line 1, control characters are not allowed ``` Fix it by treating the files as binary before writing them to get around any encoding issues, since the stream handler is a raw io object anyway. Closely related to #1906 Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
adamleff
changed the title
aaronlippold
pushed a commit
to aaronlippold/inspec
that referenced
this pull request
Jun 8, 2017
On Windows, we ran into the problem that the execution of inherited profiles would (sometimes) not work. This was due to the use of `File.read` and `File.write` and handling inside the file provider, which works in most cases (especially *nix systems), but does not behave as expected on Windows. A better and more correct way of treating these files is via binary read and write mode, which changes the underlying encoding of both strings that are passed along. Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
aaronlippold
pushed a commit
to aaronlippold/inspec
that referenced
this pull request
Jun 8, 2017
On Windows, `inspec archive` would sometimes produce incorrect archive files. These would look fine, as tgz files, but would not execute correctly. This would lead to bewildering error messages like this one: ``` Unable to parse inspec.yml: line 1, control characters are not allowed ``` Fix it by treating the files as binary before writing them to get around any encoding issues, since the stream handler is a raw io object anyway. Closely related to inspec#1906 Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
|
Likely caused: #1790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, we ran into the problem that the execution of inherited profiles would (sometimes) not work. This was due to the use of
File.readandFile.writeand handling inside the file provider, which works in most cases (especially *nix systems), but does not behave as expected on Windows. A better and more correct way of treating these files is via binary read and write mode, which changes the underlying encoding of both strings that are passed along.Signed-off-by: Dominik Richter dominik.richter@gmail.com