Don't send HTTP headers that have nil values #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Net::HTTP does not gracefully handle HTTP options/headers that have nil values. This updates Fetchers::Url to verify that all headers we attempt to configure have non-nil, non-empty values. This originally surfaced via the audit cookbook with the chef-automate fetcher in use without the data_collector token being set. Signed-off-by: Adam Leff <adam@leff.co>
chris-rock
reviewed
Jun 21, 2017
| opts = {} | ||
| opts[:ssl_verify_mode] = OpenSSL::SSL::VERIFY_NONE if @insecure | ||
|
|
||
| if @config['server_type'] == 'automate' |
There was a problem hiding this comment.
I think we should deprecate all delivery specific handling in this class and move all the required logic into audit cookbook files/default/vendor/chef-automate/fetcher.rb. I understand that we do not want to make this in one move. But I'd like to see a follow-up on that PR to cover that. This allows us to have the chef-* specific parts in one place.
There was a problem hiding this comment.
Yeah, that makes sense to me. I didn't want to tackle that in this PR but rather just add the error checking. Some better tests need to be written when we do that, and probably before, also.
adamleff
force-pushed
the
adamleff/validate-http-headers
branch
from
99a252c to
02f274a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net::HTTP does not gracefully handle HTTP options/headers that have nil values. This updates Fetchers::Url to verify that all headers we attempt to configure have non-nil, non-empty values.
This originally surfaced via the audit cookbook with the chef-automate fetcher in use without the data_collector token being set.