Fix loading profile files when executing multiple profiles #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `inspec exec` with multiple profiles, such as: inspec exec profile1 profile2 ... profile1 control calls to `inspec.profile.file` will incorrectly try to pull files from profile2 because the RuntimeProfile object is stored on the backend object, and we share the backend object. This change ensures each profile has a unique backend object to ensure the RuntimeProfile instance is not overwritten. Signed-off-by: Adam Leff <adam@leff.co>
arlimus
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
inspec execwith multiple profiles, such as:inspec exec profile1 profile2
... profile1 control calls to
inspec.profile.filewill incorrectly try to pull files from profile2 because the RuntimeProfile object is stored on the backend object, and we share the backend object.This change ensures each profile has a unique backend object to ensure the RuntimeProfile instance is not overwritten.
Fixes #2004