http resource: supply max-time option using read_timeout and open_timeout #2289
Conversation
There was a problem hiding this comment.
@bdellegrazie thanks for your first PR to InSpec! Great contribution!
Unfortunately, you have some test failures. The curl commands get mocked by our MockLoader so we can test the resource end-to-end, and they use exact matches against the command. Because your PR changed the command, the mocks are no longer valid. You can find the mocks configured here:
https://github.com/chef/inspec/blob/master/test/helper.rb#L455-L466
Essentially, you need to add your new flag so the commands are properly mocked and then you should be fine.
You can run the tests manually on your workstation like so:
- bundle install
- bundle exec m test/unit/resources/http_test.rb
If you run the above BEFORE you fix the mocks, you should see errors indicating "command not mocked" that will give you more clues.
|
@adamleff certainly, will do. |
…eout Curl doesn't distinguish between them so need to use the sum of both as the overall timeout. fixes inspec#2288 Signed-off-by: Brett Delle Grazie <brett.dellegrazie@gmail.com>
bdellegrazie
force-pushed
the
fix_2288
branch
from
ec40467 to
66691d2
Compare
|
@adamleff updated, please re-review at your earliest convenience, thanks! |
Curl doesn't distinguish between them so need to use the sum of both as
the overall timeout.
fixes #2288