Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx resource: support quoted identifiers #2292

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Conversation

adamleff
Copy link
Contributor

@adamleff adamleff commented Nov 7, 2017

An nginx config may contain configuration settings that are quoted, such as a map entry:

"~^\/opcache-api" 1;

The nginx_conf resource was failing to properly parse these.

Fixes #2278

An nginx config may contain configuration settings that are quoted, such
as a map entry:

"~^\/opcache-api" 1;

The `nginx_conf` resource was failing to properly parse these.

Signed-off-by: Adam Leff <adam@leff.co>
@adamleff adamleff requested a review from a team as a code owner November 7, 2017 20:07
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement @adamleff

@adamleff adamleff added the Type: Bug Feature not working as expected label Nov 8, 2017
@adamleff adamleff merged commit 0a11280 into master Nov 8, 2017
@adamleff adamleff deleted the adamleff/parslet-fun branch November 8, 2017 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants