security_policy resource: use PID for filename instead of random #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Quick <jquick@chef.io>
|
Excellent catch @jquick! |
jquick
force-pushed
the
jq/security_policy_uniq_pid
branch
from
ef7c49f to
c0ac3ed
Compare
Signed-off-by: Jared Quick <jquick@chef.io>
jquick
force-pushed
the
jq/security_policy_uniq_pid
branch
from
c0ac3ed to
afb149f
Compare
adamleff
changed the title
adamleff
approved these changes
Dec 4, 2017
|
Thank you for fixing this @jquick !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the security policy when used with the new Train caching. Since it creates a unique export name every call it will not be cached. This change was originally created to protect from parallel runners. Moving it to Process.pid will allow it to be cached as well as protect from parallel runners.
Signed-off-by: Jared Quick jquick@chef.io