Bugfix: make registry_key resource case-insensitive #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding this @alexpop |
chris-rock
changed the title
|
@arlimus added fix to this PR |
| # convert keys to lower case | ||
| return @registy_cache = Hash[@registy_cache.map do |key, value| | ||
| [key.downcase, value] | ||
| end] |
There was a problem hiding this comment.
could we:
begin
keys = JSON.parse(cmd.stdout)
@registry_cache = ... blah ...
rescue JSON::ParseError => _
@registry_cache = nil
end
@registry_cache
This also avoids a duplicate return statement.
|
Thank you @alexpop , this is an awesome addition! Thanks @chris-rock for extending our tests. |
arlimus
added a commit
that referenced
this pull request
Nov 24, 2015
Bugfix: make registry_key resource case-insensitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration test for
NtlmMinClientSecOnce #254 is fixed, we should add a test for
NTLMMinServerSec