Fix legacy reporter output to file #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Quick <jquick@chef.io>
jquick
force-pushed
the
jq/fix_legacy_reporter_output
branch
from
651eb33 to
e2c29d4
Compare
jquick
changed the title
miah
approved these changes
Feb 16, 2018
Signed-off-by: Jared Quick <jquick@chef.io>
chris-rock
approved these changes
Feb 17, 2018
lib/inspec/base_cli.rb
Outdated
|
|
||
| # see if we are using the legacy output to write to files | ||
| if opts['output'] | ||
| opts['format'] = "#{opts['format']}:#{opts['output']}" |
There was a problem hiding this comment.
I think we should print that this is deprecated and will be removed in inspec 3.0
Signed-off-by: Jared Quick <jquick@chef.io>
jquick
force-pushed
the
jq/fix_legacy_reporter_output
branch
from
f7c4adc to
272fe85
Compare
kagarmoe
pushed a commit
that referenced
this pull request
Feb 19, 2018
* Fix legacy reporter output. Signed-off-by: Jared Quick <jquick@chef.io> * Wrap test in a proc to catch warnings. Signed-off-by: Jared Quick <jquick@chef.io> * Add output deprecation. Signed-off-by: Jared Quick <jquick@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with test-kitchen when trying to output the results to a file. That use to use the old rspec file writer but now it set to use the new format.
Fixes #2656
Signed-off-by: Jared Quick jquick@chef.io