Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove supports binding for generic resources #2848

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

jquick
Copy link
Contributor

@jquick jquick commented Mar 20, 2018

We ran into an issue were the AWS transport was trying to parse some YAML. This resource was previously locked down to only OS's. This change opens up the generic resources(yaml, csv, json) to be able to be used with any transport.

Fixes #2846

Signed-off-by: Jared Quick jquick@chef.io

Signed-off-by: Jared Quick <jquick@chef.io>
@jquick jquick requested a review from a team as a code owner March 20, 2018 16:59
@jquick jquick added the Type: Enhancement Improves an existing feature label Mar 20, 2018
Copy link
Contributor

@jerryaldrichiii jerryaldrichiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @jquick, looks good to me.

Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you yay!! 🎊

@arlimus arlimus merged commit 4f6aa79 into master Mar 21, 2018
@arlimus arlimus deleted the jq/remove_generic_supports branch March 21, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants