Add automate reporter #2902
Add automate reporter #2902
Conversation
jquick
force-pushed
the
jq/automate_reporter
branch
2 times, most recently
from
2d89d30 to
fe38949
Compare
Signed-off-by: Jared Quick <jquick@chef.io>
jquick
force-pushed
the
jq/automate_reporter
branch
from
fe38949 to
644ac27
Compare
| # This hashes the passed string into SHA1. | ||
| # Then it downgrades the 160bit SHA1 to a 128bit | ||
| # then we format it as a valid UUIDv5. | ||
| def uuid_from_string(string) |
lib/inspec/reporters/automate.rb
Outdated
| Net::HTTP.start(uri.hostname, | ||
| uri.port, | ||
| use_ssl: uri.scheme == 'https', | ||
| verify_mode: OpenSSL::SSL::VERIFY_NONE) do |http| |
There was a problem hiding this comment.
Can we make this a config option? I would like to go to a world where we verify it
Signed-off-by: Jared Quick <jquick@chef.io>
jquick
force-pushed
the
jq/automate_reporter
branch
from
5b8f9f9 to
90c5d2a
Compare
lib/inspec/reporters/automate.rb
Outdated
| super(config) | ||
|
|
||
| # default to using no ssl for sending reports | ||
| @config['use_ssl'] = @config['use_ssl'] || false |
There was a problem hiding this comment.
Would @config['use_ssl'] ||= false work here?
There was a problem hiding this comment.
I think use_ssl is not precise, because we use ssl in any case. The only difference is that in one case we validate the certificate and in the other we don't. Maybe @config['verify_ssl'] = @config['verify_ssl'] || false
| @backend.platform[field] | ||
| rescue Train::Error => e | ||
| Inspec::Log.error(e.message) | ||
| nil |
There was a problem hiding this comment.
I think we should document, why it is okay to ignore the error here
lib/inspec/reporters/automate.rb
Outdated
| super(config) | ||
|
|
||
| # default to using no ssl for sending reports | ||
| @config['use_ssl'] = @config['use_ssl'] || false |
There was a problem hiding this comment.
I think use_ssl is not precise, because we use ssl in any case. The only difference is that in one case we validate the certificate and in the other we don't. Maybe @config['verify_ssl'] = @config['verify_ssl'] || false
Signed-off-by: Jared Quick <jquick@chef.io>
Adds the automate reporter to send directly to automate. Currently this report is only usable via the
--json-configas it requires additional metadata.Fixes #2547
Signed-off-by: Jared Quick jquick@chef.io