Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amazon linux service mgmt detection #2970

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Amazon linux service mgmt detection #2970

merged 1 commit into from
Apr 19, 2018

Conversation

meringu
Copy link
Contributor

@meringu meringu commented Apr 17, 2018

Looks like when support for Amazon Linux 2 was added, detection for Amazon 1 had this bug introduced:

# Current behavior
> '2015.03'.start_with?('20\d\d')
=> false

# Proposed behavior
> '2015.03 =~ /^20\d\d/
=> 0

This change also adds a test for both Amazon linux 1 and 2 service detection. I haven't touched the tests for inspec before, please let me know If I should improve my change.

@meringu
Amazon linux service mgmt detection
898bdbc 
Signed-off-by: Henry Muru Paenga <meringu@gmail.com>
@meringu meringu requested a review from a team as a code owner April 17, 2018 22:39
jquick
jquick approved these changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @meringu ! Nice enhancement

@jquick jquick added the Type: Enhancement Improves an existing feature label Apr 18, 2018
miah
miah approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @meringu !

@jquick jquick merged commit a9e3b8d into inspec:master Apr 19, 2018
@meringu meringu deleted the amazon branch April 19, 2018 23:56
@meringu
Copy link
Contributor Author

meringu commented Apr 19, 2018

Thanks @jquick and @miah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miah miah miah approved these changes

@jquick jquick jquick approved these changes

Assignees
No one assigned
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meringu @miah @jquick