Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add train GCP transport #3046

Merged
merged 1 commit into from
May 16, 2018
Merged

Add train GCP transport #3046

merged 1 commit into from
May 16, 2018

Conversation

jquick
Copy link
Contributor

@jquick jquick commented May 14, 2018

Signed-off-by: Jared Quick jquick@chef.io

This change includes the Train pin for the new GCP features as well as a berkshelf update which is needed to support it.

This is manually testing of Train master for now. Will be updated once the Train gem is released.

@jquick jquick requested a review from a team as a code owner May 14, 2018 15:41
@jquick jquick force-pushed the jq/add_train_gcp branch 19 times, most recently from fad33f7 to 916fe0e Compare May 16, 2018 17:25
@jquick jquick changed the title Add train GCP transport (DO NOT MERGE) Add train GCP transport May 16, 2018
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the Berkshelf changes? (what's the connection to the train pin?)

@jquick
Copy link
Contributor Author

jquick commented May 16, 2018

GCP depends had some conflicts with Berkshelf. This was resolved by upgrading it on train and inspec.

@jquick jquick force-pushed the jq/add_train_gcp branch 2 times, most recently from e85e3c8 to 0659644 Compare May 16, 2018 18:02
Signed-off-by: Jared Quick <jquick@chef.io>
@jquick jquick force-pushed the jq/add_train_gcp branch from 0659644 to eae3486 Compare May 16, 2018 18:34
@jquick jquick merged commit 40e7c1b into master May 16, 2018
@jquick jquick deleted the jq/add_train_gcp branch May 16, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants