separate RSpec handling in runner #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and restore profile tests that had been completely mocked until now
We need to put those tickets back in the semaphore, otherwise the remaining tests never get executed. doh
srenatus
force-pushed
the
dr/separate-rspec
branch
from
a13d003 to
20b1387
Compare
|
sigh turning down concurrency solves the issue locally, but triggers a timeout (no output for 10 minutes) on Travis. 😒 |
|
It's not a train issue after all, https://travis-ci.org/chef/inspec/jobs/102517662 uses 0.9.4, too, and I've just re-run its tests successfully. |
chris-rock
force-pushed
the
dr/separate-rspec
branch
from
b7f456b to
20b1387
Compare
| # | ||
| # @param backend [BackendRunner] exposing the target to resources | ||
| # @return [ResourcesDSL] | ||
| def self.create_dsl(backend) |
There was a problem hiding this comment.
much better to have the dsl in here ...
chris-rock
added a commit
that referenced
this pull request
Jan 19, 2016
separate RSpec handling in runner
|
@chris-rock thanks a lot! Any ideas what had happened here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has so far prevented us from writing some critical unit tests for profile structure and test loading. By separating it and adding a Mock runner we can now test for profile structure. (more MRs to come)