auditd_rules rework #400
Merged
auditd_rules rework #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/auditd_rules-rework
branch
from
8fc449f to
ff76342
Compare
srenatus
force-pushed
the
sr/auditd_rules-rework
branch
from
ff76342 to
765f058
Compare
srenatus
force-pushed
the
sr/auditd_rules-rework
branch
from
765f058 to
698e4e6
Compare
| it { should cmp 0 } | ||
| end | ||
|
|
||
| **Query properties of rules targetting specific syscalls or files.** |
srenatus
force-pushed
the
sr/auditd_rules-rework
branch
from
698e4e6 to
19296db
Compare
srenatus
force-pushed
the
sr/auditd_rules-rework
branch
from
7d39c2c to
8eaa98f
Compare
arlimus
force-pushed
the
sr/auditd_rules-rework
branch
from
8eaa98f to
5849b02
Compare
|
this turned out to be an awesome improvement!! :) |
arlimus
force-pushed
the
sr/auditd_rules-rework
branch
from
5849b02 to
2e6fbc1
Compare
|
👍 |
srenatus
force-pushed
the
sr/auditd_rules-rework
branch
from
2e6fbc1 to
bbec06e
Compare
|
blocked by unit tests failing after winrm update: #439 |
TODO: unit tests for the legacy format
Move to a more mathematical representation of version numbers comparisons. The existing one is semantically correct, but may lead to slight confusion.
arlimus
force-pushed
the
sr/auditd_rules-rework
branch
from
bbec06e to
971d651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312 and #309, without dropping support for the old syntax. (Also documents the old
statusmethod.)The new features, however, you only get with an not-outdated version of the
auditpackage.Adds a utility class for chaining filter methods that could be useful in more places, I hope.
Note that I couldn't find a way to have
MockLoaderpresent the outdated format, so I've just dropped that test for now.