Skip to content

Commit 558b339

Browse files
committed
feat: add some best practices
1 parent 95ae912 commit 558b339

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

index.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,16 +63,27 @@ module.exports = {
6363
}],
6464
'valid-typeof': 'error',
6565

66-
'array-bracket-spacing': ['error', 'never'],
66+
// Best Practices (http://eslint.org/docs/rules/#best-practices)
67+
'accessor-pairs': 'error',
6768
'array-callback-return': 'error',
69+
'block-scoped-var': 'off', // todo: enable?
70+
'class-methods-use-this': 'off',
71+
'complexity': 'off', // todo: enable?
72+
'consistent-return': 'error',
73+
'curly': ['error', 'multi-line', 'consistent'],
74+
'default-case': 'error',
75+
'dot-location': ['error', 'property'],
76+
'dot-notation': 'error',
77+
'eqeqeq': ['error', 'allow-null'],
78+
// todo continue the list
79+
80+
'array-bracket-spacing': ['error', 'never'],
6881
'brace-style': ['error', '1tbs'],
6982
'camelcase': 'error',
7083
'comma-dangle': 'off',
7184
'comma-spacing': ['error', {after: true, before: false}],
7285
'comma-style': 'error',
73-
'curly': ['error', 'multi-line', 'consistent'],
7486
'eol-last': 'error',
75-
'eqeqeq': ['error', 'allow-null'],
7687
'func-call-spacing': 'error',
7788
'indent': ['error', 4, {SwitchCase: 1}],
7889
'key-spacing': 'error',

0 commit comments

Comments
 (0)