fix: double click event handling #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOM `pointerdown` and `pointerup` do not contain number of click in `detail` like `click` events. So I tweak `GenericEditorArea.eventHappened` to call `handleDoubleClick` on `GenericMouseEvent.MOUSE_CLICKED` Closes: #225
|
@targos Do you confirm I must PR https://github.com/Actelion/openchemlib for java changes ? |
Yes |
tpoisseau
added a commit
to tpoisseau/openchemlib
that referenced
this pull request
Oct 9, 2024
It's needed for https://github.com/cheminfo/openchemlib-js project DOM `pointerdown` and `pointerup` do not contain number of click in `detail` like `click` events. So I tweak `GenericEditorArea.eventHappened` to call `handleDoubleClick` on `GenericMouseEvent.MOUSE_CLICKED` Refs: cheminfo/openchemlib-js#232
|
Done |
|
Update of OCL in #233 fixed the issue according to my tests on the cloudflare preview. |
Deploying openchemlib-js with
|
| Latest commit: |
69f9d12
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://688c3247.openchemlib-js.pages.dev |
| Branch Preview URL: | https://225-double-click-on-atom--bo.openchemlib-js.pages.dev |
|
Ok, I updated openchemlib submodule (and update the copy). Seems works as expected. |
|
But I already updated the submodule and the copy in #233 |
|
Yes, So I just merged and added comment (so we don't think it's missing). This PR remove |
targos
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOM
pointerdownandpointerupdo not contain number of click indetaillikeclickevents.So I tweak
GenericEditorArea.eventHappenedto callhandleDoubleClickonGenericMouseEvent.MOUSE_CLICKEDCloses: #225