Skip to content

Commit 4346537

Browse files
authored
Merge pull request kubernetes-sigs#224 from DirectXMan12/infra/pr-templates
🏃 PR Templates
2 parents 8991a78 + b199283 commit 4346537

File tree

6 files changed

+59
-8
lines changed

6 files changed

+59
-8
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
name: Breaking change (X)
3+
about: A breaking change to the API surface or expected behavior of this project.
4+
5+
---
6+
7+
<!-- please add a :warning: (`:warning:`) to the title of this PR, and delete this line and similar ones -->
8+
9+
<!-- What does this do, and why do we need it? -->
10+
11+
<!-- Why does this have to be a breaking change (what else did you consider)? -->
+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
name: Bug fix (Z)
3+
about: A bug fix that doesn't otherwise change API surface
4+
5+
---
6+
7+
<!-- please add a :bug: (`:bug:`) to the title of this PR, and delete this line and similar ones -->
8+
9+
<!-- What does this do, and why do we need it? -->
10+
11+
<!-- What issue does this fix (e.g. Fixes #XYZ) -->
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
name: Backwards-compatible feature (Y)
3+
about: A new feature that adds to the API surface or behavior, but doesn't break backwards compatibility
4+
5+
---
6+
7+
<!-- please add a :sparkles: (`:sparkles:`) to the title of this PR, and delete this line and similar ones -->
8+
9+
<!-- What does this do, and why do we need it? -->

.github/PULL_REQUEST_TEMPLATE/docs.md

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
name: Documentation
3+
about: A change to the documentation of this repository
4+
5+
---
6+
7+
<!-- please add a :book: (`:book:`) to the title of this PR, and delete this line and similar ones -->
8+
9+
<!-- What docs does this change, and why? -->
+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
name: Tests/Infra/Other
3+
about: A change to the tests in this repo, the utilities scripts, or some other piece of infrastructure tooling
4+
5+
---
6+
7+
<!-- please add a :running: (`:running:`) to the title of this PR, and delete this line and similar ones -->
8+
9+
<!-- What does this do, and why do we need it? -->

VERSIONING.md

+10-8
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,10 @@ to match the PR. For instance, if you have a bugfix in with a breaking
100100
change, it's generally encouraged to submit the bugfix separately, but if
101101
you must put them in one PR, mark the commit separately.
102102

103+
*Commits marked separately will be treated similiarly to a distinct PR by
104+
the cherrypick scripts*. Therefore, only use them if you want the given
105+
commit to be considered separately.
106+
103107
### Commands and Workflow
104108

105109
controller-runtime follows the standard Kubernetes workflow: any PR needs
@@ -126,17 +130,15 @@ will evaluate when to do a major release as it comes up.
126130

127131
### Exact Steps
128132

129-
1. Generate release notes using the release note tooling (***TODO***)
130-
131-
2. Add a release for controller-runtime on GitHub, using those release
132-
notes
133+
1. (*if doing a minor or patch release*) Update the release-X branch with
134+
the latest set of changes using the cherrypick tooling (***TODO***)
133135

134-
3. Add a release for controller-tools on GitHub (folowing a similar
135-
process for controller-tools release notes).
136+
2. Generate release notes using the release note tooling (***TODO***)
136137

137-
4. Publish associated binaries and release tarballs (***TODO***)
138+
3. Add a release for controller-runtime on GitHub, using those release
139+
notes, with a title of `vX.Y.Z`.
138140

139-
5. Announce the release in `#kubebuilder` on Slack with a pinned message.
141+
4. Announce the release in `#kubebuilder` on Slack with a pinned message.
140142

141143
### Breaking Changes
142144

0 commit comments

Comments
 (0)