Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove css check or just throw a warning on invalid CSS rules. #57

Open
OlavHN opened this issue Dec 16, 2014 · 1 comment
Open

Remove css check or just throw a warning on invalid CSS rules. #57

OlavHN opened this issue Dec 16, 2014 · 1 comment

Comments

@OlavHN
Copy link

OlavHN commented Dec 16, 2014

Thanks for a great lib!

So far I've run into missing css rules for 'display: flex' and 'filter: XX'. Just an omission in chenglou/valid-css-props or is there a set of supported browsers?

If it would just throw a warning it would make it easy to send a PR and wait for the warnings to disappear instead of having to use a fork.

@chenglou
Copy link
Owner

(Related: #56)

Display flex definitely works. Filter is an omission. I forgot where I took the list but it probably didn't include it because it's experimental (https://developer.mozilla.org/en-US/docs/Web/CSS/filter). No ie support. But hey, who am I to say which browser you should support =)

Maybe it should be added to valid-css-props. You can submit a PR there and I'll make sure to sync it back here asap. Using a warning certainly seems to make sense in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants