Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto size modal height #15

Open
marcodpt opened this issue Aug 19, 2018 · 4 comments
Open

Auto size modal height #15

marcodpt opened this issue Aug 19, 2018 · 4 comments

Comments

@marcodpt
Copy link

Is there a way of modal height be computed with the slot html?
My main problem is that for my use i cannot pass a fix height for the modal, because vary a lot depend on the form that user will trigger!

@zacharytyhacz
Copy link

zacharytyhacz commented Jul 31, 2019

I agree, I was just having this issue by using a modal to preview a video, though the videos can be different sizes/dimensions.

You can try fiddling around with the class styles as a work-around to try:

.vodal-dialogue {
    /* .... */
}

However, I do agree with you that the size properties should have an auto value to be given to just fit the contents within.

Something like this maybe?

<vodal :show="true" :height="'auto'" :width="'auto'" ... ... ...></vodal>

Another note that I would like to see is a max_width / max_height, however this can be done in CSS, though not programmatically depending on certain conditions if it were to change.

EDIT
Having something like this implemented may help out this issue as well that is also a problem I have ran into in the past with using these vodals:

@weblabio
Copy link

+1
while the height is static - the plugin cannot be used :(

@zacharytyhacz
Copy link

+1
while the height is static - the plugin cannot be used :(

Have you tried overriding with CSS ?

@fabionixweb
Copy link

.vodal-dialog {
height: max-content !important;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants