Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging variables #140

Closed
mmahalwy opened this issue Feb 8, 2016 · 2 comments
Closed

packaging variables #140

mmahalwy opened this issue Feb 8, 2016 · 2 comments

Comments

@mmahalwy
Copy link

mmahalwy commented Feb 8, 2016

I see we have checks for node_env to be development or not, but process envs don't get packaged in (for example, I packaged with production NODE_ENV). Thoughts about this?

@chentsulin
Copy link
Member

That's why we only check process.env.process === 'development' for now. If eventually we have to check something like: process.env.process === 'production', we have to add some scripts into our build step.

It seems that you already find some good enough suggestions:

@chentsulin
Copy link
Member

The easiest solution I can find is that set default NODE_ENV to production at first line of main.js

process.env.NODE_ENV = process.env.NODE_ENV || 'production';

@mmahalwy What do you think?

chentsulin added a commit that referenced this issue Mar 2, 2016
Close #140, set default NODE_ENV to production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants