Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not record unconnected calls / voicemail #563

Closed
mesvam opened this issue Jul 4, 2024 · 3 comments · Fixed by #564
Closed

Does not record unconnected calls / voicemail #563

mesvam opened this issue Jul 4, 2024 · 3 comments · Fixed by #564
Assignees
Labels
enhancement New feature or request

Comments

@mesvam
Copy link

mesvam commented Jul 4, 2024

BCR does not start recording until call is successfully connected, and so does not record the beginning of outgoing calls. One important example is calls that go to voicemail sometimes go unrecorded

It would be useful to have an option to also record these "one-sided" conversations, for example, to keep a recording of the voicemail that was sent to another person.

To reproduce: call a non-existent number such as (555) 555-5555, or dial a number that goes to voicemail (only sometimes)

@mesvam mesvam changed the title Can't record voicemail / does not record unconnected calls Does not record unconnected calls / voicemail Jul 4, 2024
@chenxiaolong
Copy link
Owner

BCR currently only starts recording when Android reports that the call enters the ACTIVE state. Calls to non-existent numbers remain in the DIALING state until they disconnect.

#564 adds a toggle to start recording as soon as the call enters the DIALING state (though it's disabled by default). Please give this test build a try: BCR-1.65.r2.g2f92c39-release.zip

As for voicemails, please enable debug mode by long pressing BCR's version number, reproduce the problem, and then upload the log file that BCR creates in the output directory. When a call reaches voicemail, the call should always enter the ACTIVE state, but it's possible your device's modem has a bug and doesn't do that. The log file will contain details about all the states the call goes through.

I wasn't able to reproduce the problem on my Pixel 8 Pro. I tried 10 times each of having the other party hang up immediately and also just ignoring the call to let it time out and go to voicemail.

@chenxiaolong chenxiaolong self-assigned this Jul 10, 2024
@chenxiaolong chenxiaolong added the enhancement New feature or request label Jul 10, 2024
@mesvam
Copy link
Author

mesvam commented Jul 11, 2024

Thanks so much! I could not always reproduce the voicemail issue either (I only discovered some voicemail recordings seemed missing), but I will try to debug it further with that build. Perhaps it only happens with certain carriers

@mesvam
Copy link
Author

mesvam commented Jan 16, 2025

#564 adds a toggle to start recording as soon as the call enters the DIALING state (though it's disabled by default). Please give this test build a try: BCR-1.65.r2.g2f92c39-release.zip

Just to report back, I tried with this toggle enabled on another phone, and I usually got silence while it was dialing until it hit voicemail or the "number invalid" message etc., but that's probably an Android thing. It did record the voice mailbox prompt and the voicemail though, so it's still useful. With the toggle off (record on ACTIVE), it wouldn't ever start recording at all, so you would not capture the voicemail you sent to another person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants