Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix decodeCredentialJWT function [DEV-3170] #342

Merged
merged 2 commits into from
Sep 4, 2023
Merged

fix: Fix decodeCredentialJWT function [DEV-3170] #342

merged 2 commits into from
Sep 4, 2023

Conversation

abdulla-ashurov
Copy link
Contributor

No description provided.

@abdulla-ashurov abdulla-ashurov self-assigned this Sep 1, 2023
@ankurdotb
Copy link
Contributor

Task linked: DEV-3170 Credential-Service: Fix problem with 'verifyStatus=true' parameter in '/credential/verify' API

@abdulla-ashurov abdulla-ashurov changed the title fix: Fix decodeCredentialJWT function fix: Fix decodeCredentialJWT function [DEV-3170] Sep 1, 2023
@Eengineer1
Copy link
Contributor

Eengineer1 commented Sep 4, 2023 •
edited
Loading

For clarification,

The verification would fail for JWT credentials that wouldn't repeat body properties that exist top-level as well.

There's the removeOriginalFields boolean option that controls this behaviour by default, during issuance.

Let's consider if any additional property top-level is required to construct the underlying credential body, which is utilised during function i/o intercommunication convention by design.

PS: This is a trivial point within the VC-JWT spec, a conversation that we had, whence this implication is a direct outcome.

Eengineer1
Eengineer1 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved current state re-construction.

Let's assess if any additional top-level properties are required, as mentioned.

@Eengineer1 Eengineer1 merged commit c5330fb into develop Sep 4, 2023
@Eengineer1 Eengineer1 deleted the DEV-3170 branch September 4, 2023 11:43
cheqd-bot bot pushed a commit that referenced this pull request Sep 4, 2023
@semantic-release-bot
chore(release): 3.6.7-develop.1 [skip ci]
8870034 
## [3.6.7-develop.1](3.6.6...3.6.7-develop.1) (2023-09-04)

### Bug Fixes

* Fix decodeCredentialJWT function [DEV-3170] ([#342](#342)) ([c5330fb](c5330fb))
@cheqd-bot
Copy link

cheqd-bot bot commented Sep 4, 2023

🎉 This PR is included in version 3.6.7-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Sep 4, 2023
@semantic-release-bot
chore(release): 3.6.7 [skip ci]
f1b1b5c 
## [3.6.7](3.6.6...3.6.7) (2023-09-04)

### Bug Fixes

* Fix decodeCredentialJWT function [DEV-3170] ([#342](#342)) ([c5330fb](c5330fb))
@cheqd-bot
Copy link

cheqd-bot bot commented Sep 4, 2023

🎉 This PR is included in version 3.6.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Sep 4, 2023
@abdulla-ashurov abdulla-ashurov mentioned this pull request Sep 5, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eengineer1 Eengineer1 Eengineer1 approved these changes

Assignees

@abdulla-ashurov abdulla-ashurov

Labels
released on @beta released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdulla-ashurov @ankurdotb @Eengineer1