Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When an invalid HTTP request is send in (without \r) it still reaches the proxy #1235

Open
skinkie opened this issue Nov 9, 2019 · 0 comments
Open

When an invalid HTTP request is send in (without \r) it still reaches the proxy #1235

skinkie opened this issue Nov 9, 2019 · 0 comments

Comments

@skinkie
Copy link
Member

skinkie commented Nov 9, 2019

Issue #1226 defines a HTTP requests that is not using CRLF (\r\n) to separate headers. In handler_proxy.c:483 we are explicitly looking for CHR_CR, which is not found returning a bad gateway. Should the error code be set differently to show that request was poorly formed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skinkie