Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower default threshold for recall #909

Closed
pieroit opened this issue Sep 13, 2024 · 2 comments
Closed

Lower default threshold for recall #909

pieroit opened this issue Sep 13, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers memory

Comments

@pieroit
Copy link
Member

pieroit commented Sep 13, 2024

New embedder models (especially multilingual) are way more finegraned and conservative than embedders from a few months ago.

If a threshold of 0.7/0.8 was reasonable then, it is not now and it should be way lower.

It is possible to change thresholds via plugin (e.g. Cat Advanced Tools), but the default ones should also be lowered.

Intervention point: here

@pieroit pieroit added enhancement New feature or request good first issue Good for newcomers memory labels Sep 13, 2024
@scicco
Copy link

scicco commented Sep 16, 2024

Hello, I've seen the tag 'good first issue' and I tried to start contributing to this feature.

@pieroit
Copy link
Member Author

pieroit commented Oct 21, 2024

Merging soon

@pieroit pieroit closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers memory
Projects
None yet
Development

No branches or pull requests

2 participants