Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify GitHub action versions #1017

Closed
jim opened this issue Mar 18, 2022 · 2 comments
Closed

Specify GitHub action versions #1017

jim opened this issue Mar 18, 2022 · 2 comments
Labels
🐞Bug Something isn't working 📦 Dependency Update Updating one or more dependencies Good First Issue Good First Issue Help Wanted Extra attention is needed

Comments

@jim
Copy link
Member

jim commented Mar 18, 2022

Describe the bug

We are using various GitHub actions in our CI pipeline. Some of them are pointing to the main branches of the respective repo, which means they are a moving target. We recently had an issue where CI failed because a bug was introduced in one of the setup actions we use.

To fix this, let's lock any GitHub actions to specific versions. This all lives in .github/workflows/ci.yml.
@jim jim added 🐞Bug Something isn't working Help Wanted Extra attention is needed Good First Issue Good First Issue 📦 Dependency Update Updating one or more dependencies labels Mar 18, 2022
@MrFuku MrFuku mentioned this issue Mar 20, 2022
Merged
4 tasks
@MrFuku
Copy link
Contributor

MrFuku commented Mar 20, 2022

@jim Nice to meet you!
I have created a PR that solves this problem, if you would like to take a look at it?
#1018

@jim
Copy link
Member Author

jim commented Mar 21, 2022

Fixed by #1018.

Thank you for the contribution!

@jim jim closed this as completed Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞Bug Something isn't working 📦 Dependency Update Updating one or more dependencies Good First Issue Good First Issue Help Wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jim @MrFuku