Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow members to renew A tools even after they are overdue #1637

Open
phinze opened this issue Aug 14, 2024 · 0 comments
Open

Allow members to renew A tools even after they are overdue #1637

phinze opened this issue Aug 14, 2024 · 0 comments

Comments

@phinze
Copy link
Contributor

phinze commented Aug 14, 2024

We noticed that tools that are member renewable don't allow renewal once the due date is past, and we decided this restriction should be lifted.

Here's the code with the clause that can be removed:

within_renewal_limit? && item.borrow_policy.member_renewable? && ended_at.nil?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant