Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated re-style with new CSS. #42

Closed
wants to merge 4 commits into from

Conversation

cameronlowry
Copy link
Contributor

No description provided.

filter: drop shadow is not widely supported. Using Youtube style with
box shadow and border radius.
@cameronlowry
Copy link
Contributor Author

I am not great with Git so I am not sure how to properly create a clean pull request with only the last commit.

@chieffancypants
Copy link
Owner

Cool! Thanks again for the help, this version works well for me. My only concern now is that a new element was added that includes its own styles. As you noticed, for it to look good, you had to edit the CSS on the example app, which means this is a breaking change (visually, anyway).

In other words, every developer using the loading bar who has overridden the blue color will have a messed up looking loading bar as soon as they update.

Can you think of any ways to accomplish this in a backwards-compatible way?

Re-wrote blur effect to avoid breaking changes introduced by extra dom
element.
This is now truly a non-breaking change.
@cameronlowry
Copy link
Contributor Author

I've made 2 commits here. The first one is still technically a breaking change since the pseudo element needs to be over-written in the app.css. The second commit provides a very similar effect without the pseudo element and should be a non-breaking change.

@chieffancypants chieffancypants mentioned this pull request Feb 22, 2014
@chieffancypants
Copy link
Owner

Perfect! Thanks so much for the help. I'm going to squash all this down into a single commit and merge into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants