Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner, Bootstrap 3 z-index conflict #53

Closed
8bitsquid opened this issue Apr 15, 2014 · 4 comments
Closed

Spinner, Bootstrap 3 z-index conflict #53

8bitsquid opened this issue Apr 15, 2014 · 4 comments
Milestone

Comments

@8bitsquid
Copy link

In Bootstrap 3 the default z-index for .navbar-static-top is 1000 and the #loading-bar-spinner's z-index is 100. So if you're using a .navbar-static-top as you navigation header, the spinner will not be visible unless you change its z-index to >= 1001.

Not a big deal obviously, just thought I'd mentioned in case someone gets stuck.

[edited] chieffancypants pointed out I meant to say to set the spinner's z-index >= to 1001, not <= 1001

@chieffancypants
Copy link
Owner

good to know, thanks! The point of the spinner is to be on top, so if a z-index of 100 isn't enough, it should be increased by default. For clarification, you mean to change the spinner's z-index to >= 1001 right?

@gruppjo
Copy link

gruppjo commented Apr 17, 2014

Hi, had the same problem today.

If found out it's actually 1030. Check out the source!
https://github.com/twbs/bootstrap/blob/2127eb563fafdad10d004d33533a44ad023440e5/less/variables.less#L254

@chieffancypants
Copy link
Owner

@gruppjo you found a new class (fixed instead of static). The spinner should be on top of both, so thanks for pointing that out!

I'll publish a fix later today

@chieffancypants chieffancypants added this to the 0.4.0 milestone Apr 17, 2014
@chieffancypants
Copy link
Owner

So, I totally forgot I did this, but this was fixed in 2bc4045 but was never published to npm/bower. Will be published in a few minutes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants