Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpcfill beta - Card backside doesn't load with partial frontside name #165

Closed
1 task done
bwsinger opened this issue Aug 16, 2023 · 2 comments
Closed
1 task done
Assignees
Labels
beta feedback Feedback on the new frontend's open beta

Comments

@bwsinger
Copy link
Contributor

bwsinger commented Aug 16, 2023

System

  • Browser (including version): Chrome Version 115.0.5790.114

Affected Components

  • Backend

Description

When using Fuzzy search and a partial card name is used, if the resulting best match is a double sided card the backside will not be queried. If the full name of the front side of a double sided card is queried, then the backside will be queried.

Steps to Reproduce

Server URL: https://mpcfill.com
Card Text Query:

Birgi
Birgi, God of Storytelling

Video Demo:
mpcfill-bug2

@ndepaola ndepaola self-assigned this Aug 16, 2023
@ndepaola ndepaola added the beta feedback Feedback on the new frontend's open beta label Aug 16, 2023
@ndepaola
Copy link
Collaborator

this is the expected behaviour at present because we match the front query to a DFC pair before querying anything from the backend, so your search settings don't factor into it at all - but i agree that it should work the way you expect - just hadn't really considered what people would expect to happen in the fuzzy search case. thanks for raising this, i'll address this and close the issue when it's done :) fwiw this is purely related to the frontend

@ndepaola
Copy link
Collaborator

this has been addressed - if you have fuzzy search turned on, the frontend will now associate your query with a DFC pair if a pair's front name starts with your query. if it's ambiguous - i.e. two or more DFC pair front names start with your query - no match will be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta feedback Feedback on the new frontend's open beta
Projects
Development

No branches or pull requests

2 participants