Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue even if some PRs fails #100

Closed
Borda opened this issue Jan 12, 2021 · 2 comments
Closed

Continue even if some PRs fails #100

Borda opened this issue Jan 12, 2021 · 2 comments
Assignees
@chinthakagodawita
Labels
bug Something isn't working

Comments

@Borda
Copy link

Borda commented Jan 12, 2021

Hi @chinthakagodawita,
I have a follow-up question to #19 it seems that after trying to work forked PR which is very common in opensource the bot just dies, right? so even there are other PR it could resolve it just stop with reaching the first difficult PR...
So would it be possible to change this error as a warning (eventually add an argument such as "continue-if-fails") and continue with other PRs?
just for the record: Lightning-AI/pytorch-lightning#5451
and build: https://github.com/PyTorchLightning/pytorch-lightning/runs/1686819251?check_suite_focus=true#step:3:88
@Borda Borda mentioned this issue Jan 12, 2021
Closed
@chinthakagodawita
Copy link
Owner

Ouch, good find @Borda - should have this fixed, hopefully within the next week!

@chinthakagodawita chinthakagodawita self-assigned this Jan 13, 2021
@chinthakagodawita chinthakagodawita added the bug Something isn't working label Jan 13, 2021
@Borda Borda mentioned this issue Jan 13, 2021
Merged
12 tasks
@chinthakagodawita
Copy link
Owner

Hey @Borda - this should be fixed by #102 which has just been released as part of v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chinthakagodawita chinthakagodawita

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chinthakagodawita @Borda