Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setApprovalForAll virtual #148

Closed
KirienzoEth opened this issue Mar 3, 2022 · 5 comments
Closed

Make setApprovalForAll virtual #148

KirienzoEth opened this issue Mar 3, 2022 · 5 comments

Comments

@KirienzoEth
Copy link
Contributor

Hello!

Would it be possible to make setApprovalForAll virtual? That's the case in OpenZeppelin's ERC721 implementation. Or are there any reasons why isApprovedForAll is virtual, but not setApprovalForAll?

It would be useful because of the various gas optimization strategies involving approving marketplace proxys by default (among others), which require you to override isApprovedForAll to add some custom logic.

IMHO, some custom logic is also necessary in setApprovalForAll so users can revoke those default approvals the same way they'd revoke any address's approvals, thus why I would like to be able to override that method.

@Vectorized
Copy link
Collaborator

Sounds good. You can make a PR.

@cygaar what do you think?

@KirienzoEth
Copy link
Contributor Author

Will do today :)

@KirienzoEth
Copy link
Contributor Author

KirienzoEth commented Mar 4, 2022

Done here: #149
If there is anything else I need to do please do not hesitate

@cygaar
Copy link
Collaborator

cygaar commented Mar 8, 2022

PR merged

@cygaar cygaar closed this as completed Mar 8, 2022
@KirienzoEth
Copy link
Contributor Author

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants