-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make setApprovalForAll virtual #148
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
Would it be possible to make
setApprovalForAll
virtual? That's the case in OpenZeppelin's ERC721 implementation. Or are there any reasons whyisApprovedForAll
is virtual, but notsetApprovalForAll
?It would be useful because of the various gas optimization strategies involving approving marketplace proxys by default (among others), which require you to override
isApprovedForAll
to add some custom logic.IMHO, some custom logic is also necessary in
setApprovalForAll
so users can revoke those default approvals the same way they'd revoke any address's approvals, thus why I would like to be able to override that method.The text was updated successfully, but these errors were encountered: