Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_setOwnersExplicit is not used #7

Closed
MrMcGoats opened this issue Jan 20, 2022 · 3 comments
Closed

_setOwnersExplicit is not used #7

MrMcGoats opened this issue Jan 20, 2022 · 3 comments

Comments

@MrMcGoats
Copy link

_setOwnersExplicit has internal visibility, but is never called. I understand this could still be useful for implementations extending ERC721A, however, the current contract can be used as-is and this function is effectively just wasting gas in its current state.

I think it would make sense to either remove it entirely or add it as an optional extension. Or even possibly add an external function that does nothing other than call _setOwnersExplicit.

@cygaar
Copy link
Collaborator

cygaar commented Jan 22, 2022

We are going to be adding this as an optional extension

@NeoDigi
Copy link
Contributor

NeoDigi commented Jan 29, 2022

This can probably be close be #34

@cygaar
Copy link
Collaborator

cygaar commented Jan 29, 2022

Cool, moved to an extension as part of #34

@cygaar cygaar closed this as completed Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants