Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(googlechromebeta) fix update script #2399

Conversation

TheCakeIsNaOH
Copy link
Member

Description

As omahaproxy has shut down, the update script broke. This switches to using the official google version history api for google chrome.

Motivation and Context

Fixes #2398

How Has this Been Tested?

Tested update script on Windows 10, tested package in chocolatey test env.

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

As omahaproxy has shut down, the update script broke. This switches to using the official google version history
api for google chrome.
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@mems
Copy link

mems commented Mar 11, 2024

@pauby, is it possible to review this PR that reflect the same changes made for googlechrome (stable) made by @rdenny-vdc?
Thank you :)

@pauby
Copy link
Member

pauby commented Mar 11, 2024

@mems there is a hold on merging PR's just now until we release chocolatey-au and update this repository.

However, note that there are no reviewers on this PR and anybody in the team can pick it up.

@TheCakeIsNaOH
Copy link
Member Author

This package no longer works in this repository, as it will fail due to the validation extension flagging the no prerelease in the ID rule.

Closing this PR until the pack failure with this package is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(googlechromebeta) Broken update script
4 participants