Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new GitHub action to run yarn npm audit on a pull request #393

Closed
2 tasks done
st3phhays opened this issue Apr 2, 2024 · 1 comment
Closed
2 tasks done

Add new GitHub action to run yarn npm audit on a pull request #393

st3phhays opened this issue Apr 2, 2024 · 1 comment
Assignees
@st3phhays
Labels
4 - Done Code has been added to the repository, and has been reviewed by a team member Improvement Issues that enhances existing functionality, or adds new features

Comments

@st3phhays
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

Sometimes it's hard to know if we're introducing a vulnerability to choco-theme before we ship it. With Yarn 4, we can run yarn npm audit to find these.

Describe The Solution. Why is it needed?

We should create a GitHub action to run on PRs that will automatically run and report the findings of yarn npm audit. This will ensure we check this before shipping choco-theme.

Additional Context

This has been reintroduced in Yarn 4, which is included with choco-theme 0.6.0.

Related Issues

No response
@st3phhays st3phhays added Improvement Issues that enhances existing functionality, or adds new features 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint labels Apr 2, 2024
@st3phhays st3phhays added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint labels May 9, 2024
@st3phhays st3phhays self-assigned this May 9, 2024
@st3phhays
Copy link
Member Author

This was released with 0.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st3phhays st3phhays

Labels
4 - Done Code has been added to the repository, and has been reviewed by a team member Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@st3phhays