Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condition should be == #89

Closed
rainarch opened this issue Aug 17, 2017 · 4 comments
Closed

Condition should be == #89

rainarch opened this issue Aug 17, 2017 · 4 comments

Comments

@rainarch
Copy link

crfsuite/lib/crf/src/crf1d_model.c

Line 779 in 8c0028c

if (buffer_orig = NULL) {

@usptact
Copy link

usptact commented Aug 17, 2017

Dupe #73

@jlerouge
Copy link
Contributor

jlerouge commented Aug 18, 2017 •
edited
Loading

Well spotted !
I think #85 fixes just that.

@chokkan
Copy link
Owner

chokkan commented Aug 23, 2017

Sorry for not merging the PRs for so long...

@chokkan chokkan closed this as completed Aug 23, 2017
@usptact
Copy link

usptact commented Aug 23, 2017 •
edited
Loading

@chokkan Thank you so much for the software package (I used it almost daily) and for maintaining it!

It would be nice also to bump the version of the package to reflect the new changes ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chokkan @usptact @jlerouge @rainarch