Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bash] Performance improvement #26

Open
chr0mag opened this issue Jan 9, 2022 · 0 comments
Open

[bash] Performance improvement #26

chr0mag opened this issue Jan 9, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@chr0mag
Copy link
Owner

chr0mag commented Jan 9, 2022

The Bash version iterates over the entire list of IP blocks for all countries and appends to the country set files as it goes. Repeatedly writing to disk is slow and significant performance benefits can be had by sorting the IP blocks into per-country lists in memory and writing them all out to files in one go.

See #16 and #24 for results of making this improvement to the maxmind provider in the Python version.

Note that the Bash version is basically legacy at this point and I have no intention of making this change myself. However, if someone is actively using the Bash version and wishes to do the work, I will happily accept a PR.

@chr0mag chr0mag added enhancement New feature or request help wanted Extra attention is needed labels Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant