Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history delete doesn't work #452

Closed
AndreKR opened this issue Apr 8, 2023 · 11 comments
Closed

history delete doesn't work #452

AndreKR opened this issue Apr 8, 2023 · 11 comments
Labels
bug Something isn't working

Comments

@AndreKR
Copy link

AndreKR commented Apr 8, 2023

I was on Clink 1.4.22.something. I have a history items 1 to 136, as shown by history. I typed history delete 136 and if I remember correctly it showed something like "Deleted item 136". But a subsequent history would still show the item.

I then updated to Clink 1.4.23.5fc3fc. I now have a history with items 1 to 139. If I type history delete 136 now I get "Unable to delete history item 136.".

I now typed history clear and that worked.

@chrisant996
Copy link
Owner

chrisant996 commented Apr 8, 2023

I can reproduce the same.

@chrisant996 chrisant996 added needs more information The issue needs clarifying information investigation needed Deeper investigation is needed and removed needs more information The issue needs clarifying information labels Apr 8, 2023
@chrisant996 chrisant996 added bug Something isn't working and removed investigation needed Deeper investigation is needed labels Apr 8, 2023
@chrisant996
Copy link
Owner

It was broken for 25 months, since v1.1.43. Apparently history delete # isn't used very often.

@codermonkey55
Copy link

@chrisant996 , I just ran into this myself; glad to see it has been fixed. Any estimates on when the new version with the fix will be published?

@chrisant996
Copy link
Owner

It's been that way for 25 months, and there's a workaround, so it doesn't seem urgent. Clink v1.4.24 will be published in the next few days, when some other changes are ready.

@chrisant996
Copy link
Owner

Oops, I successfully caught the COVID (first time; fully vaxxed, incl. bivalent booster).

I'm not going to publish a new version of Clink until after I'm better. There's no sense risking regressions due to brain fog, or risking inability to apply fixes in a timely manner if a regression were to occur.

@codermonkey55
Copy link

It's been that way for 25 months, and there's a workaround, so it doesn't seem urgent. Clink v1.4.24 will be published in the next few days, when some other changes are ready.

What's the workaround?

@chrisant996
Copy link
Owner

chrisant996 commented Apr 18, 2023

Oops. I mixed up two issues. 448 has a workaround. 452 does not.

I expect to publish v1.4.24 in a few days, after the worst of the COVID symptoms have passed. Interestingly, yesterday was the first day of symptoms and I was feeling bad last night, but by 6am my fever had broken and it seems I'm beginning to feel better. With any luck, maybe this will be a mild/short case.

@codermonkey55
Copy link

No worries, like you said, it's not urgent. Regarding your COVID, hope that's truly the case and it's a mild/short case.

@chrisant996
Copy link
Owner

I published v1.4.24.

My COVID continues to fade. So I decided I may as well publish the update. It seems I'm one of the lucky ones that has a super mild/fast response to this strain. No complaints here! My wife got hit hard for many days a few months ago, but we managed to isolate so it didn't spread to me. I've even been able to keep working full time (from home), and the impact is less than most colds. 🤷‍♂️ I attribute it to the vaccines/boosters, and to my generally strong immune system. Phew.

@codermonkey55
Copy link

codermonkey55 commented Apr 18, 2023

I attribute it to the vaccines/boosters, and to my generally strong immune system. Phew.

💪

@codermonkey55
Copy link

Install release v1.4.24 and confirmed history delete is working, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants