Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clink incorrectly shows certain commands as quoted #654

Closed
gamer191 opened this issue Aug 9, 2024 · 2 comments
Closed

Clink incorrectly shows certain commands as quoted #654

gamer191 opened this issue Aug 9, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@gamer191
Copy link

gamer191 commented Aug 9, 2024

The command echo "hi^"&calc" will show everything after the word "echo" as quoted (yellow). This is incorrect, because the quotes escape the escape character, leaving the 2nd quote unescaped

This could be a minor security issue, as users could hypothetically be social engineered into running a command with an escaped end quote

@chrisant996
Copy link
Owner

Thanks for reporting this.

This led to finding lots of subtle quirks in parsing of ^ and " and @ in various contexts.

@chrisant996 chrisant996 added the bug Something isn't working label Aug 9, 2024
@chrisant996
Copy link
Owner

Several recent commits have fixed this, and various related quirks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants