-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement subtitle support #462
Comments
I would love to see subtitles support in Tunarr - it makes it a lot harder to make anime channels without subtitles. Maybe an option for selecting a default audio track, too? |
Would love this, we pretty much always run with subtitles on my dizquetv setup |
I don't really have much experience with typescript, but I'm happy to take a stab at getting external subs working! |
@avedor PRs always welcome! |
Would love subtitles to be implemented. Or if we have to search for subtitles in the same folder as the file. |
I've taken a look a little at both embedded subs in an mkv container and at subs in the same dir. Jellyfin, at least, didn't seem to return the remote path for the subtitles or an ID, so may be more to implement than initially thought. I think I'm close on embedded subs, just can't seem to get ffmpeg to add the subtitles m3u8 to the master.m3u8 file, but this whole stack is new to me XD I've been working on things in an MR on my fork that you're welcome to peep. Might help steer things along @diblaze |
If i've understood things correctly, i've now mapped the subtitle stream the same way audio is mapped and the the only thing i have to figure out is how to get |
Since we've removed the Plex transcoder, we need to bring back subtitle support with an 'in house' implementation. Of course, this is quite complicated, so we'll probably break it up into chunks:
The text was updated successfully, but these errors were encountered: