Skip to content

Commit 6723899

Browse files
newrengitster
authored andcommittedJun 21, 2023
merge-ll: rename from ll-merge
A long term (but rather minor) pet-peeve of mine was the name ll-merge.[ch]. I thought it made it harder to realize what stuff was related to merging when I was working on the merge machinery and trying to improve it. Further, back in d1cbe1e ("hash-ll.h: split out of hash.h to remove dependency on repository.h", 2023-04-22), we have split the portions of hash.h that do not depend upon repository.h into a "hash-ll.h" (due to the recommendation to use "ll" for "low-level" in its name[1], but which I used as a suffix precisely because of my distaste for "ll-merge"). When we discussed adding additional "*-ll.h" files, a request was made that we use "ll" consistently as either a prefix or a suffix. Since it is already in use as both a prefix and a suffix, the only way to do so is to rename some files. Besides my distaste for the ll-merge.[ch] name, let me also note that the files ll-fsmonitor.h, ll-hash.h, ll-merge.h, ll-object-store.h, ll-read-cache.h would have essentially nothing to do with each other and make no sense to group. But giving them the common "ll-" prefix would group them. Using "-ll" as a suffix thus seems just much more logical to me. Rename ll-merge.[ch] to merge-ll.[ch] to achieve this consistency, and to ensure we get a more logical grouping of files. [1] https://lore.kernel.org/git/kl6lsfcu1g8w.fsf@chooglen-macbookpro.roam.corp.google.com/ Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent dd77d58 commit 6723899

13 files changed

+13
-13
lines changed
 

‎Documentation/technical/api-merge.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ and `diff.c` for examples.
2828

2929
* `struct ll_merge_options`
3030

31-
Check ll-merge.h for details.
31+
Check merge-ll.h for details.
3232

3333
Low-level (single file) merge
3434
-----------------------------
3535

36-
Check ll-merge.h for details.
36+
Check merge-ll.h for details.

‎Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1051,7 +1051,6 @@ LIB_OBJS += linear-assignment.o
10511051
LIB_OBJS += list-objects-filter-options.o
10521052
LIB_OBJS += list-objects-filter.o
10531053
LIB_OBJS += list-objects.o
1054-
LIB_OBJS += ll-merge.o
10551054
LIB_OBJS += lockfile.o
10561055
LIB_OBJS += log-tree.o
10571056
LIB_OBJS += ls-refs.o
@@ -1060,6 +1059,7 @@ LIB_OBJS += mailmap.o
10601059
LIB_OBJS += match-trees.o
10611060
LIB_OBJS += mem-pool.o
10621061
LIB_OBJS += merge-blobs.o
1062+
LIB_OBJS += merge-ll.o
10631063
LIB_OBJS += merge-ort.o
10641064
LIB_OBJS += merge-ort-wrappers.o
10651065
LIB_OBJS += merge-recursive.o

‎apply.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#include "gettext.h"
2222
#include "hex.h"
2323
#include "xdiff-interface.h"
24-
#include "ll-merge.h"
24+
#include "merge-ll.h"
2525
#include "lockfile.h"
2626
#include "name-hash.h"
2727
#include "object-name.h"

‎builtin/checkout.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#include "gettext.h"
1414
#include "hex.h"
1515
#include "hook.h"
16-
#include "ll-merge.h"
16+
#include "merge-ll.h"
1717
#include "lockfile.h"
1818
#include "mem-pool.h"
1919
#include "merge-recursive.h"

‎convert.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#include "sub-process.h"
1616
#include "trace.h"
1717
#include "utf8.h"
18-
#include "ll-merge.h"
18+
#include "merge-ll.h"
1919
#include "wrapper.h"
2020

2121
/*

‎diff.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
#include "submodule.h"
2727
#include "hashmap.h"
2828
#include "mem-pool.h"
29-
#include "ll-merge.h"
29+
#include "merge-ll.h"
3030
#include "string-list.h"
3131
#include "strvec.h"
3232
#include "graph.h"

‎merge-blobs.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#include "git-compat-util.h"
22
#include "run-command.h"
33
#include "xdiff-interface.h"
4-
#include "ll-merge.h"
4+
#include "merge-ll.h"
55
#include "blob.h"
66
#include "merge-blobs.h"
77
#include "object-store.h"

‎ll-merge.c ‎merge-ll.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include "attr.h"
1111
#include "xdiff-interface.h"
1212
#include "run-command.h"
13-
#include "ll-merge.h"
13+
#include "merge-ll.h"
1414
#include "quote.h"
1515
#include "strbuf.h"
1616
#include "wrapper.h"

‎ll-merge.h ‎merge-ll.h

File renamed without changes.

‎merge-ort.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
#include "gettext.h"
3131
#include "hex.h"
3232
#include "entry.h"
33-
#include "ll-merge.h"
33+
#include "merge-ll.h"
3434
#include "match-trees.h"
3535
#include "mem-pool.h"
3636
#include "object-name.h"

‎merge-recursive.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "environment.h"
2121
#include "gettext.h"
2222
#include "hex.h"
23-
#include "ll-merge.h"
23+
#include "merge-ll.h"
2424
#include "lockfile.h"
2525
#include "match-trees.h"
2626
#include "name-hash.h"

‎notes-merge.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include "diffcore.h"
1313
#include "hex.h"
1414
#include "xdiff-interface.h"
15-
#include "ll-merge.h"
15+
#include "merge-ll.h"
1616
#include "dir.h"
1717
#include "notes.h"
1818
#include "notes-merge.h"

‎rerere.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include "xdiff-interface.h"
1313
#include "dir.h"
1414
#include "resolve-undo.h"
15-
#include "ll-merge.h"
15+
#include "merge-ll.h"
1616
#include "attr.h"
1717
#include "path.h"
1818
#include "pathspec.h"

0 commit comments

Comments
 (0)
Please sign in to comment.