Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONDITIONING connection gets dropped on workflow change #235

Open
gonzalu opened this issue Oct 7, 2024 · 5 comments
Open

CONDITIONING connection gets dropped on workflow change #235

gonzalu opened this issue Oct 7, 2024 · 5 comments
Labels
compatibility working with other nodes

Comments

@gonzalu
Copy link

gonzalu commented Oct 7, 2024

Not sure if it is me or the nodes... In the setup below, every time I load or reload the workflow, this connection gets a * and I have to re-drag the connection to re-enable it...

BEFORE (upon reloading the workflow)
image

AFTER (after reconnecting the noodle)
image

Thanks...

@chrisgoringe chrisgoringe added the compatibility working with other nodes label Oct 7, 2024
@chrisgoringe
Copy link
Owner

That's an issue with UE working with "Switch (Any)". Because the type that is being output isn't defined when the connection gets made...

I will investigate and see if there is a workaround.

@gonzalu
Copy link
Author

gonzalu commented Oct 7, 2024

I figured as much :( No worries... all good :D

Thanks Chris

@JorgeR81
Copy link

JorgeR81 commented Nov 9, 2024

I also had this issue.

Now, I use a "pass" node after the switches, and it works perfectly.

This aegisflow_utility_nodes has "pass" nodes for most data types.
It was created specifically to work with cg-use-everywhere.

https://github.com/aegis72/aegisflow_utility_nodes

pass


@chrisgoringe, if you can't find a better solution, maybe you should just have a version of this in cg-use-everywhere

These "pass" nodes are essential to use a switch + UE node.

But this extension has not been updated for a while, with the exception a more recent PR.

@gonzalu
Copy link
Author

gonzalu commented Nov 10, 2024

That's a cool trick. However, i can report that since switching the clip text encode nodes feeding the switch from Cubiq's text param nodes to the comfyui-core text encoder nodes, the switch to use everywhere connection no longer gets severed 🤷‍♂️

@JorgeR81
Copy link

Glad to know you've found a solution.

Anyways, in case you ever need it, keep in mind that the "pass" nodes also work for other tipes of data.

data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility working with other nodes
Projects
None yet
Development

No branches or pull requests

3 participants