Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement islamic, persian and um al qura calendars #19

Merged
merged 1 commit into from
Nov 29, 2023
Merged

feat: implement islamic, persian and um al qura calendars #19

merged 1 commit into from
Nov 29, 2023

Conversation

chrisimcevoy
Copy link
Owner

  • First pass at implementic Islamic, Persian and Um Al Qura calendars.
  • Fleshed out LocalTime, LocalDate and LocalDateTime to the extent that is required for calendar tests
  • Added TODOs for tests which rely on dotnet's Base Class Library calendars. In Noda Time, these tests are intended to check consistency against BCL implementations of specific calendar systems, but obviously we don't have access to that. I have a couple of ideas about how to create something roughly equivalent to these tests, but I don't want to do any of them in the context of this PR.

@chrisimcevoy chrisimcevoy merged commit 705a0a3 into master Nov 29, 2023
5 checks passed
@chrisimcevoy chrisimcevoy deleted the implement-remaining-calendars branch November 29, 2023 22:14
@chrisimcevoy chrisimcevoy mentioned this pull request Nov 23, 2023
Closed
@chrisimcevoy chrisimcevoy mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
python tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chrisimcevoy