Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement resolvers #240

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat: implement resolvers #240

merged 1 commit into from
Jan 9, 2025

Conversation

chrisimcevoy
Copy link
Owner

  • Ports the following Noda Time delegates to Protocols which describe different types of "resolver":
    • AmbiguousTimeResolver
    • SkippedTimeResolver
    • ZoneLocalMappingResolver
  • Implements the Resolvers class which contains commonly-used implementations of the above.

Relates to:

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 88.76404% with 20 lines in your changes missing coverage. Please review.

Project coverage is 95.99%. Comparing base (5590c34) to head (fd7fa2b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tests/time_zones/test_resolvers.py 90.00% 8 Missing ⚠️
pyoda_time/_zoned_date_time.py 66.66% 4 Missing ⚠️
pyoda_time/time_zones/_zone_local_mapping.py 60.00% 4 Missing ⚠️
pyoda_time/time_zones/_resolvers.py 94.73% 3 Missing ⚠️
pyoda_time/_offset_date_time.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   95.96%   95.99%   +0.03%     
==========================================
  Files         256      259       +3     
  Lines       19431    19606     +175     
==========================================
+ Hits        18646    18821     +175     
  Misses        785      785              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisimcevoy chrisimcevoy merged commit c1b4452 into main Jan 9, 2025
8 of 9 checks passed
@chrisimcevoy chrisimcevoy deleted the implement-resolvers branch January 9, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant